refactor(nf*): remove useless check builder

Author: Nicoss54

libs/native-federation/src/builders/build/builder.ts

@@ -45,7 +45,6 @@ import { createSharedMappingsPlugin } from '../../utils/shared-mappings-plugin';
 // import { NextHandleFunction } from 'vite';
 import { FederationInfo } from '@softarc/native-federation-runtime';
 import { PluginBuild } from 'esbuild';
-import { checkAngularBuildApplicationBuilder } from '../../utils/check-builder';
 import { getI18nConfig, translateFederationArtefacts } from '../../utils/i18n';
 
 function _buildApplication(options, context, pluginsOrExtensions) {
@@ -75,7 +74,7 @@ export async function* runBuilder(
   if (builder === '@angular-devkit/build-angular:browser-esbuild') {
     logger.info('.: NATIVE FEDERATION - UPDATE NEEDED :.');
     logger.info('');
-    logger.info("Since version 17.1, Native Federation uses Angular's");
+    logger.info('Since version 17.1, Native Federation uses Angular\'s');
     logger.info('Application-Builder and its Dev-Server.');
     logger.info('');
     logger.info('If you are sill on Angular 17.0.x, please update to');
@@ -143,7 +142,7 @@ export async function* runBuilder(
     server: 'server',
     media: 'media',
     ...(typeof outputPath === 'string' ? undefined : outputPath),
-    base: typeof outputPath === 'string' ? outputPath : outputPath.base,
+    base: typeof outputPath === 'string' ? outputPath : outputPath.base
   };
 
   const i18n = await getI18nConfig(context);
@@ -169,7 +168,7 @@ export async function* runBuilder(
     tsConfig: options.tsConfig,
     verbose: options.verbose,
     watch: false, // options.watch,
-    dev: !!nfOptions.dev,
+    dev: !!nfOptions.dev
   };
 
   const activateSsr = nfOptions.ssr && !nfOptions.dev;
@@ -186,8 +185,8 @@ export async function* runBuilder(
             (e) => e !== 'tslib'
           );
         }
-      },
-    },
+      }
+    }
   ];
 
   // SSR build fails when externals are provided via the plugin
@@ -220,13 +219,13 @@ export async function* runBuilder(
           'Content-Type': mimeType,
           'Access-Control-Allow-Origin': '*',
           'Access-Control-Allow-Methods': 'GET, POST, PUT, DELETE',
-          'Access-Control-Allow-Headers': 'Content-Type',
+          'Access-Control-Allow-Headers': 'Content-Type'
         });
         res.end(body);
       } else {
         next();
       }
-    },
+    }
   ];
 
   const memResults = new MemResults();
@@ -270,28 +269,27 @@ export async function* runBuilder(
 
   options.deleteOutputPath = false;
 
-  const appBuilderName = checkAngularBuildApplicationBuilder()
-    ? '@angular/build:application'
-    : '@angular-devkit/build-angular:application';
+  const appBuilderName = '@angular/build:application';
+
 
   const builderRun = runServer
     ? serveWithVite(
-        normOuterOptions,
-        appBuilderName,
-        _buildApplication,
-        context,
-        nfOptions.skipHtmlTransform
-          ? {}
-          : { indexHtml: transformIndexHtml(nfOptions) },
-        {
-          buildPlugins: plugins as any,
-          middleware,
-        }
-      )
+      normOuterOptions,
+      appBuilderName,
+      _buildApplication,
+      context,
+      nfOptions.skipHtmlTransform
+        ? {}
+        : { indexHtml: transformIndexHtml(nfOptions) },
+      {
+        buildPlugins: plugins as any,
+        middleware
+      }
+    )
     : buildApplication(options, context, {
-        codePlugins: plugins as any,
-        indexHtmlTransformer: transformIndexHtml(nfOptions),
-      });
+      codePlugins: plugins as any,
+      indexHtmlTransformer: transformIndexHtml(nfOptions)
+    });
 
   // builderRun.output.subscribe(async (output) => {
   for await (const output of builderRun) {
@@ -410,7 +408,7 @@ function addDebugInformation(fileName: string, rawBody: string): string {
 
   const sharedForVite = shared.map((s) => ({
     ...s,
-    packageName: `/@id/${s.packageName}`,
+    packageName: `/@id/${s.packageName}`
   }));
 
   remoteEntry.shared = [...shared, ...sharedForVite];

libs/native-federation/src/schematics/appbuilder/schematic.ts

@@ -3,7 +3,6 @@ import { Rule, Tree } from '@angular-devkit/schematics';
 import { MfSchematicSchema } from './schema';
 
 import * as path from 'path';
-import { checkAngularBuildApplicationBuilder } from '../../utils/check-builder';
 
 type NormalizedOptions = {
   polyfills: string;
@@ -41,10 +40,8 @@ function updateWorkspaceConfig(
   }
 
   if (projectConfig.architect.esbuild) {
-    projectConfig.architect.esbuild.builder =
-      checkAngularBuildApplicationBuilder()
-        ? '@angular/build:application'
-        : '@angular-devkit/build-angular:application';
+    projectConfig.architect.esbuild.builder = '@angular/build:application';
+
     projectConfig.architect.esbuild.options.browser =
       projectConfig.architect.esbuild.options.main;
     delete projectConfig.architect.esbuild.options.main;

libs/native-federation/src/schematics/init/schematic.ts

@@ -26,7 +26,6 @@ import {
 } from '@schematics/angular/utility/dependencies';
 
 import * as path from 'path';
-import { checkAngularBuildApplicationBuilder } from '../../utils/check-builder';
 
 const SSR_VERSION = '^2.0.10';
 
@@ -238,9 +237,7 @@ function updateWorkspaceConfig(
     console.log(
       'Switching project to the application builder using esbuild ...'
     );
-    originalBuild.builder = checkAngularBuildApplicationBuilder()
-      ? '@angular/build:application'
-      : '@angular-devkit/build-angular:application';
+    originalBuild.builder = '@angular/build:application';
     delete originalBuild.configurations?.development?.buildOptimizer;
     delete originalBuild.configurations?.development?.vendorChunk;
   }