Skip to content

Conversation

@mborgerson
Copy link
Member

Start paving the way to better analysis management:

  • Move analysis scheduling out of Workspace
    • Fix implicit coupling causing analyses to not run due to scheduling in callbacks (e.g. if CFG was not selected)
  • Move some analysis configuration validation out
  • Decouple some callbacks
  • Actually test all analyses being run

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 66.84783% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.30%. Comparing base (b4c1c52) to head (35b8dc0).

Files with missing lines Patch % Lines
angrmanagement/data/jobs/cfg_generation.py 15.21% 35 Missing and 4 partials ⚠️
angrmanagement/ui/workspace.py 73.07% 7 Missing and 7 partials ⚠️
angrmanagement/logic/analysis_manager.py 90.00% 2 Missing and 2 partials ⚠️
...ngrmanagement/plugins/precise_diffing/diff_view.py 0.00% 2 Missing ⚠️
angrmanagement/ui/views/code_view.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1537      +/-   ##
==========================================
+ Coverage   43.14%   43.30%   +0.15%     
==========================================
  Files         266      268       +2     
  Lines       27346    27380      +34     
  Branches     3694     3689       -5     
==========================================
+ Hits        11798    11856      +58     
+ Misses      14976    14962      -14     
+ Partials      572      562      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mborgerson mborgerson force-pushed the feat/analysis-manager branch from 880d75a to 35b8dc0 Compare November 21, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant