feat: enable server name overriding and certificate validation bypass for TLS authentification.#95
Draft
qdelamea-aneo wants to merge 1 commit intomainfrom
Draft
feat: enable server name overriding and certificate validation bypass for TLS authentification.#95qdelamea-aneo wants to merge 1 commit intomainfrom
qdelamea-aneo wants to merge 1 commit intomainfrom
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
bad9e7f to
31af813
Compare
…bypass for TLS authentification.
31af813 to
88ff459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TLS authentication in the CLI has two limitations that complicate its use:
Description
This PR adds two flags to the CLI connection options to support these two behaviors.
Testing
Tested with local deployment of ArmoniK.
Impact
Add feature.
Additional Information
No.
Checklist