Skip to content

Comments

feat: enable server name overriding and certificate validation bypass for TLS authentification.#95

Draft
qdelamea-aneo wants to merge 1 commit intomainfrom
qd/fix-tls
Draft

feat: enable server name overriding and certificate validation bypass for TLS authentification.#95
qdelamea-aneo wants to merge 1 commit intomainfrom
qd/fix-tls

Conversation

@qdelamea-aneo
Copy link
Contributor

Motivation

TLS authentication in the CLI has two limitations that complicate its use:

  • It is not possible to override the server name during certificate validation.
  • It is not possible to bypass CA certificate validation (very useful for local development).

Description

This PR adds two flags to the CLI connection options to support these two behaviors.

Testing

Tested with local deployment of ArmoniK.

Impact

Add feature.

Additional Information

No.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
613 463 76% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 88ff459 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant