Skip to content

Conversation

@wosys
Copy link
Contributor

@wosys wosys commented Feb 22, 2025

There's no need to declare in samples' manifest.
Otherwise, it will create more icons in launcher.

@google-cla
Copy link

google-cla bot commented Feb 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wosys
Copy link
Contributor Author

wosys commented Feb 25, 2025

Hi @tjohns @bentrengrove @javadude @tnorbye ,

Could you please help me review this PR.
I see #275 , maybe it will refactor the architecture.
Then this PR may not needed then?

@javadude
Copy link
Contributor

Good catch; thanks! This will simplify the user experience.

However, the entire <intent-filter> should be removed for these, not just the <category>. For example

    <activity
        android:name=".CallNotificationSample"
        android:launchMode="singleTop"
        android:exported="true">
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />

            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
    </activity>

should become

    <activity
        android:name=".CallNotificationSample"
        android:launchMode="singleTop"
        android:exported="true"/>

There's no need to declare in samples' manifest.
Otherwise, it will create more icons in launcher.
@javadude
Copy link
Contributor

javadude commented Feb 26, 2025

I'm updating the build.yaml in PR #277 to move to the required upload-artifact@v4. Once merged, you'll need to merge in the change for this build to pass, then we can merge this PR.

@javadude
Copy link
Contributor

The build update was merged. Please merge main into your branch

@javadude javadude self-requested a review March 9, 2025 02:28
Copy link
Contributor

@javadude javadude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javadude javadude merged commit eba641b into android:main Mar 9, 2025
3 checks passed
@yrezgui
Copy link
Contributor

yrezgui commented Mar 21, 2025

/gemini summarize

@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants