-
Notifications
You must be signed in to change notification settings - Fork 2
[docs] place command after global options #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Pull request artifacts
|
WalkthroughREADME updated to modify the CLI usage example: credentials now precede the subcommand, changing from "smsgate send ..." to "smsgate -u -p send ...". No code or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
94-96: Inconsistent flag:--phonevs--phones.Other examples use
--phones; Docker snippet uses--phone. Unify to--phonesfor consistency.Apply:
-docker run -it --rm --env-file .env ghcr.io/android-sms-gateway/cli \ - send --phone '+12025550123' 'Hello, Dr. Turk!' +docker run -it --rm --env-file .env ghcr.io/android-sms-gateway/cli \ + send --phones '+12025550123' 'Hello, Dr. Turk!'
168-173: Optional: Add a brief security caution before CLI credentials example.Reinforce that passing passwords via flags may leak via shell history/process list.
Suggestion:
-Credentials can also be passed via CLI options: +Credentials can also be passed via CLI options: + +Note: Passing credentials via flags may expose them in shell history and process listings. Prefer env vars or a `.env` file when possible.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: goreleaser
🔇 Additional comments (1)
README.md (1)
171-171: Correct placement of global options before subcommand.Verified — the only occurrence is README.md:171 and it correctly places -u/-p before the subcommand:
smsgate -u <username> -p <password> send --phones '+12025550123' 'Hello, Dr. Turk!'
Summary by CodeRabbit