Skip to content

Update OS in release workflow#223

Merged
wagoodman merged 2 commits intomainfrom
update-os
Jun 29, 2023
Merged

Update OS in release workflow#223
wagoodman merged 2 commits intomainfrom
update-os

Conversation

@wagoodman
Copy link
Contributor

This makes the OS version consistent in the validations and release pipelines (important when sharing a cache between workflows). I can't seem to find a way to get the ubuntu-20.04 name/version info from the github runner context (seems to not exist actions/runner#2527 ) but that would be ideal to bake into the cache key as well.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman changed the title Update os in release workflow Update OS in release workflow Jun 29, 2023
@wagoodman wagoodman enabled auto-merge (squash) June 29, 2023 12:45
@wagoodman wagoodman merged commit cf77840 into main Jun 29, 2023
@wagoodman wagoodman deleted the update-os branch June 29, 2023 12:55
@kolyshkin
Copy link

I can't seem to find a way to get the ubuntu-20.04 name/version info from the github runner context (seems to not exist actions/runner#2527 ) but that would be ideal to bake into the cache key as well.

There is apparently ${process.env.ImageOS} (see actions/setup-go#383), which resolves to e.g. ubuntu20 or ubuntu22 (which, I guess, is OK since GHA only support LTS releases).

tomersein pushed a commit to tomersein/vunnel that referenced this pull request Jan 10, 2026
* update os in release workflow

Signed-off-by: Alex Goodman <[email protected]>

* bust cache keys

Signed-off-by: Alex Goodman <[email protected]>

---------

Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants