chore(deps): update tools to latest versions#3205
Merged
Conversation
0ff1248 to
38c1ac3
Compare
72dca16 to
8a72467
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
8a72467 to
9486b7c
Compare
A change to the rule gosec(G115) made a large amount of FP for gosec appear when updating to the latest golang-ci linter. securego/gosec#1185 securego/gosec#1149 We're going to ignore this rule for the time being while waiting for gosec to get updates so that bound checking and example snippets of `valid` code is added for this rule Signed-off-by: Christopher Phillips <[email protected]>
Contributor
|
chore: disable gosec(G115) A change to the rule gosec(G115) made a large amount of FP for gosec appear when updating to the securego/gosec#1185 We're going to ignore this rule for the time being while waiting for gosec to get updates so that We will reenable when the rule is a bit more stable and it's clear the changes we need. As a result of disabling this rule the linter would fail saying we had unused ignores. Those have been removed for the time being. |
kzantow
approved these changes
Sep 13, 2024
wagoodman
approved these changes
Sep 13, 2024
Contributor
wagoodman
left a comment
There was a problem hiding this comment.
also seems related to securego/gosec#1212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an auto-generated pull request to update all of the tools to the latest versions.