Skip to content

fix: remove undefined localStorage log message #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyiuhc merged 1 commit into from
Jan 11, 2024
Merged

fix: remove undefined localStorage log message #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/experiment-browser/src/experimentClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class ExperimentClient implements Client {
this.flags.load();
this.variants.load();
} catch (e) {
console.warn('Failed to load flags and variants from localStorage', e);
// catch localStorage undefined error
}
}

Expand Down Expand Up @@ -329,7 +329,7 @@ export class ExperimentClient implements Client {
try {
void this.variants.store();
} catch (e) {
console.warn('Failed to store variants in localStorage', e);
// catch localStorage undefined error
}
}

Expand Down Expand Up @@ -675,7 +675,7 @@ export class ExperimentClient implements Client {
try {
this.flags.store();
} catch (e) {
console.warn('Failed to store flags in localStorage', e);
// catch localStorage undefined error
}
}

Expand All @@ -698,7 +698,7 @@ export class ExperimentClient implements Client {
try {
this.variants.store();
} catch (e) {
console.warn('Failed to store variants in localStorage', e);
// catch localStorage undefined error
}
this.debug('[Experiment] Stored variants: ', variants);
}
Expand Down