feat: allow configs to take in user provided logger instances for client logging behavior #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d loggerProvider config fields
kyeh-amp
requested review from
bgiori,
sandeep-madugula,
tyiuhc,
vaibhav-jain-exp and
zhukaihan
|
📝 Documentation updates detected! New suggestion: Document custom logging configuration for JavaScript Experiment SDK |
zhukaihan
approved these changes
Nov 5, 2025
zhukaihan
reviewed
Nov 5, 2025
| * This class provides a centralized logging mechanism for the Experiment client. | ||
| * @category Logging | ||
| */ | ||
| export class AmpLogger implements Logger { |
Collaborator
There was a problem hiding this comment.
I also wonder the necessity of the wrapper given we're not doing any filtering or transformation like other SDKs. We usually want to keep experiment-browser lean.
Contributor
Author
There was a problem hiding this comment.
Great point about lean skds. I believe this is a low addition way to provide log level filtering on our end as well as have a decent buffer between our log level definitions/usages and others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes provide users with more controls over the SDK logging behavior. Users can now provide their own logger instances via client configs.
Checklist