Skip to content

fix:session storage check #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

fix:session storage check #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d046366
Fix session storage availability check
zhukaihan Mar 25, 2025
6b7b0a8
Rename func name for clarity
zhukaihan Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/experiment-browser/src/integration/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ export class IntegrationManager {

export class SessionDedupeCache {
private readonly storageKey: string;
private readonly isSessionStorageAvailable = isSessionStorageAvailable();
private readonly isSessionStorageAvailable = checkIsSessionStorageAvailable();
private inMemoryCache: Record<string, Exposure> = {};

constructor(instanceName: string) {
this.storageKey = `EXP_sent_v2_${instanceName}`;
// Remove previous version of storage if it exists.
if (isSessionStorageAvailable) {
if (this.isSessionStorageAvailable) {
safeGlobal.sessionStorage.removeItem(`EXP_sent_${instanceName}`);
}
}
Expand Down Expand Up @@ -239,7 +239,7 @@ export class PersistentTrackingQueue {
}
}

const isSessionStorageAvailable = (): boolean => {
const checkIsSessionStorageAvailable = (): boolean => {
const globalScope = getGlobalScope();
if (globalScope) {
try {
Expand Down