Skip to content

Conversation

@enumag
Copy link
Contributor

@enumag enumag commented Sep 20, 2021

This is the reason why #360 seems to be "hanging". It's because your CI configuration is kinda wrong - starting checks on both PRs and all branches means it's triggered twice. Which works on your own PRs (you just see double the checks) but breaks for cross-fork PRs. I think it expects the push checks to happen for the branch but they don't because it's on another fork.

I'm sadly not an expert on this matter but I saw it several times in the past already. Basically no cross-fork PR can ever get a success with this setup.

The common setup I see around is this:

on:
  pull_request:
  push:
    branches:
      - "master"

Basically run checks only on PRs and master. In your case I think it would be master, v3, and v3-revolt - basically all branches that are expected to be merged into / used as base branches for PRs.

@kelunik
Copy link
Member

kelunik commented Sep 23, 2021

This issue is caused by the branch protection rules rather than the workflow setup.

@kelunik kelunik closed this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants