Repository navigation
Conversation
Problem: sh attempts to execute folders because which(1) fails
to determine that although folders may have execute-bit
set, they are not executable by execv(3)-family calls
Symptom: such call is blocking, never returns (!)
Solution: check the target is a file (following symlinks).
Details: The internal which(1) clone will attempt to execute any
folder matching the Command issued. So, given the PATH of:
/usr/opt/bin/gcc <- directory
/usr/bin/gcc <- executable file
sh would attempt to execute the folder, /usr/opt/bin/gcc.
[ As executing a folder would cause sh to block indefinitely
(an unhandled OSError is thrown on exec), the test adds a ._path
value assertion first, which prevents this test from hanging when
the fix is un-applied. ]
Owner
|
Good fix, I'll schedule this for the next release |
Contributor
Author
|
glad to help, a little cross-pollination from pexpect :-) pexpect/pexpect#37 |
Owner
|
merged into release-1.10 branch |
This was referenced Oct 6, 2016
This was referenced Nov 27, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: sh attempts to execute folders because which(1) fails
to determine that although folders may have execute-bit
set, they are not executable by execv(3)-family calls
Symptom: such call is blocking, never returns (!)
Solution: check the target is a file (following symlinks).
Details: The internal which(1) clone will attempt to execute any
folder matching the Command issued. So, given the PATH of:
[ As executing a folder would cause sh to block indefinitely
(an unhandled OSError is thrown on exec), the test adds a ._path
value assertion first, which prevents this test from hanging when
the fix is un-applied. ]