[Dashing] Backport junit xml fixes for updated xunit plugin on ci.ros2.org #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ament_cmake allow speficiation of a different test runner
- By default, still uses run_test.py
- Example use case: ament_cmake_ros can use a test runner that
sets a ROS_DOMAIN_ID
Signed-off-by: Pete Baughman <[email protected]>
* ament_cmake move run_test.py to a python module
- This should let us see the history
Signed-off-by: Pete Baughman <[email protected]>
* ament_cmake refactor run_test.py into an importable python module
- Adds an ament_cmake_test python package
Signed-off-by: Pete Baughman <[email protected]>
Signed-off-by: Steven! Ragnarök <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Steven! Ragnarök <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Steven! Ragnarök <[email protected]>
) Switch to CMAKE_CURRENT_BINARY_DIR for consistency with CTest Signed-off-by: Dan Rose <[email protected]> Signed-off-by: Steven! Ragnarök <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Steven! Ragnarök <[email protected]>
Signed-off-by: Dan Rose <[email protected]> Signed-off-by: Steven! Ragnarök <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]> Signed-off-by: Steven! Ragnarök <[email protected]>
nuclearsandwich
force-pushed
the
dashing-junit-backports
branch
from
6258c1d to
949da89
Compare
Contributor
Author
|
mjcarroll
approved these changes
Mar 24, 2020
Contributor
|
LGTM other than the Linux flake. |
Contributor
Author
The build eventually ran to completion in |
Contributor
Author
|
@rotu backporting #206 will require a backport of ros2/rcutils#185 as well. I'm trying to decide if I should actually drop that PR from this backport to avoid breaking any other test code and would value your input as both a downstream Dashing user and the author of the original PR. |
Contributor
|
I’d say don’t backport #206. It’s a non-essential breaking change; @dirk-thomas thought it shouldn’t land after the feature freeze (#206 (comment)), and backporting breaking changes should be even more conservative. |
Contributor
Author
|
Excellent feedback. |
Contributor
Author
|
…ctory (#206)" This reverts commit 4354d62. Signed-off-by: Steven! Ragnarök <[email protected]>
nuclearsandwich
force-pushed
the
dashing-junit-backports
branch
from
a7ffd1d to
3ce9599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR along with its companion ament/ament_lint#224 should fix Dashing CI builds failing during the test result parsing stage on ci.ros2.org.
This PR backports #174, #181, #196, #206, #218, #221, and #225.
ament_cmake_test did not include the ament_python component when Dashing was released so in order to keep the package coherent I looked at each of the commits made to it since the Python module was added and backported all of them.