Skip to content
This repository was archived by the owner on Jul 22, 2021. It is now read-only.

fixing changes for Checking Hardware MFA Compliance for Profile Level 2 #74

Open
philipakash wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixing changes for Checking Hardware MFA Compliance for Profile Level 2 #74

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a79ded
fixing changes for MFA
Mar 1, 2018
796f0ac
fixing the empty annotation issue
Mar 1, 2018
f445fab
fixing the empty annotation issue
Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions architecture/create-benchmark-rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@
# Determine whether the root account uses hardware-based MFA.
mfa_devices = client.list_virtual_mfa_devices()['VirtualMFADevices']
for mfa_device in mfa_devices:
if not 'SerialNumber' in mfa_device:
if 'User' in mfa_device and not mfa_device['User']['Arn'].endswith('mfa/root-account-mfa-device'):
is_compliant = is_compliant and True
else:
is_compliant = is_compliant and False
Expand Down Expand Up @@ -295,7 +295,7 @@
'ComplianceResourceType': 'AWS::::Account',
'ComplianceResourceId': 'Root',
'ComplianceType': 'COMPLIANT' if is_compliant else 'NON_COMPLIANT',
'Annotation': annotation,
'Annotation': annotation+"EvaluationComplete",
'OrderingTimestamp': datetime.datetime.now(),
},
],
Expand Down