feat(SLB-468): cardinality validator improvement #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaosullivan
force-pushed
the
SLB-468-cardinality-validator-improvement
branch
from
f654a5f to
c8c5425
Compare
Extend the cardinality validator to ensure content of children blocks is checked, not just the count
nbaosullivan
force-pushed
the
SLB-468-cardinality-validator-improvement
branch
from
c8c5425 to
a9b3e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Extend the cardinality validator to ensure content of children blocks is checked, not just the count. The cardinality validator now ensures at least one counted child (or any descendant) must expose meaningful content (non-empty HTML or attributes). The rest of any validation would be left to block-specific validation, like using the required validator.