community/nodejs-current: switch to python3 for building #12138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbru31
force-pushed
the
feature/update-nodejs-current
branch
from
8157eaf to
9648603
Compare
andypost
reviewed
Nov 20, 2019
Contributor
andypost
left a comment
andypost
left a comment
There was a problem hiding this comment.
It needs more then one patch
community/nodejs-current/APKBUILD
Outdated
| source="https://nodejs.org/dist/v$pkgver/node-v$pkgver.tar.gz | ||
| dont-run-gyp-files-for-bundled-deps.patch | ||
| link-with-libatomic-on-mips32.patch | ||
| fix-gyp-python3-incompatibility.patch |
Contributor
Author
|
The question we should discuss is if we want to include so many patches and differ from the upstream release or just wait a bit longer until the upstream release is actually python3 compatible. |
Contributor
|
Better to wait, sametime gyp related update #12144 |
timbru31
force-pushed
the
feature/update-nodejs-current
branch
from
9648603 to
f7d16bf
Compare
|
This repository does not accept Pull Requests (PR) anymore. Development has moved to https://gitlab.alpinelinux.org/alpine/aports Please signup and create a Merge Request (MR) instead. Sorry for the inconvenience caused. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.