Error when trying to bookmark an Org QL view

[karthink]

OS/platform

Linux

Emacs version and provenance

Emacs 29.1, distro packages

Emacs command

emacs

Org version and provenance

Org 9.7-pre, Org development branch.

org-ql package version and provenance

0.9-pre, commit 9606aaf, straight.el recipe, straight.el

Actions taken

1. Run org-ql-search and pick org-agenda-files in the completing-read menu with the prompt "Buffers/Files: "
2. Try to bookmark the view buffer that is generated with C-x r m, bookmark-set

Observed results

The bookmark is not set, I get the error: cl-etypecase failed: org-agenda-files, (string buffer list)

Expected results

The bookmark to be set.

Backtrace

Debugger entered--Lisp error: (error "cl-etypecase failed: org-agenda-files, (string buffer list)")
  error("cl-etypecase failed: %s, %s" org-agenda-files (string buffer list))
  org-ql-view-bookmark-make-record()
  bookmark-make-record()
  bookmark-set-internal("Set bookmark named" nil overwrite)
  bookmark-set(nil nil)
  funcall-interactively(bookmark-set nil nil)
  command-execute(bookmark-set)

Etc.

The error is connected to the value of the infix option "In buffers/files" in this transient:

If appears to be set to the symbol org-agenda-files. If I refresh it by pressing i again it is set to the value of this symbol instead:

then it passes the cl-etypecase test in org-ql-view-bookmark-make-record(since it's a list) and I can bookmark it without errors.

[alphapapa]

Thanks. The "expansion" and "contraction" of that argument to org-ql-search is due for some refactoring. There are some relevant PRs but the code is complicated and coming back to it after a while makes it difficult to review. I'll fix that eventually, but in the meantime, this can probably be fixed separately.