Add support for history pages in whitehall search [WHIT-2587] #10782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifatcha
force-pushed
the
support-history-pages-in-whitehall-search
branch
2 times, most recently
from
2275ce6 to
4271ed6
Compare
kashifatcha
changed the title
kashifatcha
force-pushed
the
support-history-pages-in-whitehall-search
branch
11 times, most recently
from
e4dbbfb to
b748853
Compare
ChrisBAshton
reviewed
Nov 4, 2025
kashifatcha
force-pushed
the
support-history-pages-in-whitehall-search
branch
from
b748853 to
97d4049
Compare
ChrisBAshton
approved these changes
Nov 4, 2025
| exclude = %w[news_article speech publication] | ||
| ConfigurableDocumentType.all.filter_map do |doc| | ||
| schema = doc.settings["publishing_api_schema_name"] | ||
| next if exclude.include?(schema.to_s) |
There was a problem hiding this comment.
schema is already a string - so no need to cast it.
Suggested change
| next if exclude.include?(schema.to_s) | |
| next if exclude.include?(schema) |
I have added configurable_document_type_options which currently only returns history pages, as it is the only config-driven document type that isn't a news article sub-type. I have also created a method that merges the two types of legacy and config-driven documents into an array, and using this combined list instead of the original type_options_container so that it is displayed in the dropdown.
kashifatcha
force-pushed
the
support-history-pages-in-whitehall-search
branch
from
97d4049 to
1798ffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added configurable_document_type_options which currently only returns history pages, as it is the only config-driven document type that isn't a news article sub-type. I have also created a method that merges the two types of legacy and config-driven documents into an array, and using this combined list instead of the original type_options_container so that it is displayed in the dropdown.
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.