-
Notifications
You must be signed in to change notification settings - Fork 18
Use HTML publication header variant of inverse header #3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hannalaakso just to let you know we're close to completing the migration of this route to frontend: alphagov/frontend#4950 |
92a3e31 to
56de2a9
Compare
Thanks, @andysellick. The changes in this PR are quite small (just opened for review now, but I don’t expect much else to change). If I can get these changes released before you finish the migration, we can update your branch to include them - it’s only a line or two. Otherwise, if the migration goes in first, I’ll make a note to update the template in Frontend after our changes are merged. Does that sound okay? |
|
Thanks @jon-kirwan I'm in the middle of doing that route at the moment so I'll make a note to update it myself. |
56de2a9 to
8e07c30
Compare
MartinJJones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me and it should be possible to merge in advance of the latest inverse header style changes in the gem to avoid the wrong background colour being applied, or include the gem bump as part of this PR
This variant was previously doucumented in the gem docs but wasn't actually programatically being set anywhere. We now need to setit since it's got the standard blue background colour instead of the default light blue.
8e07c30 to
f96dd63
Compare
📣 On-going work to be aware of
Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.
Follow these steps if you are doing a Rails upgrade.
What
The HTML publication header variant was previously documented in the gem, but not actually applied anywhere in the code.
We now need to set it, as it differs from the default header by using a deeper blue background instead of the default light blue.
Review URL: https://government-frontend-pr-3860.herokuapp.com/government/publications/car-show-me-tell-me-vehicle-safety-questions/car-show-me-tell-me-vehicle-safety-questions
Why
https://gov-uk.atlassian.net/jira/software/c/projects/NAV/boards/1422?selectedIssue=NAV-18210
Anything else
Depends on
alphagov/govuk_publishing_components#5053 - I've added a Do Not Merge label until the gem PR has been merged.
Fixes https://gov-uk.atlassian.net/jira/software/c/projects/NAV/boards/1422?selectedIssue=NAV-18210.