Skip to content

Conversation

@hannalaakso
Copy link
Member

@hannalaakso hannalaakso commented Oct 8, 2025

📣 On-going work to be aware of

Routes in this application are being migrated to another application, please check with #govuk-patterns-and-pages when making changes.

  • #govuk-patterns-and-pages have been notified of this change

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

What

The HTML publication header variant was previously documented in the gem, but not actually applied anywhere in the code.

We now need to set it, as it differs from the default header by using a deeper blue background instead of the default light blue.

Review URL: https://government-frontend-pr-3860.herokuapp.com/government/publications/car-show-me-tell-me-vehicle-safety-questions/car-show-me-tell-me-vehicle-safety-questions

Why

https://gov-uk.atlassian.net/jira/software/c/projects/NAV/boards/1422?selectedIssue=NAV-18210

Anything else

Depends on

alphagov/govuk_publishing_components#5053 - I've added a Do Not Merge label until the gem PR has been merged.

Fixes https://gov-uk.atlassian.net/jira/software/c/projects/NAV/boards/1422?selectedIssue=NAV-18210.

@andysellick
Copy link
Contributor

@hannalaakso just to let you know we're close to completing the migration of this route to frontend: alphagov/frontend#4950

@jon-kirwan jon-kirwan force-pushed the update-inverse-header branch from 92a3e31 to 56de2a9 Compare October 17, 2025 11:15
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3860 October 17, 2025 11:15 Inactive
@jon-kirwan jon-kirwan marked this pull request as ready for review October 20, 2025 09:32
@jon-kirwan
Copy link
Contributor

jon-kirwan commented Oct 20, 2025

@hannalaakso just to let you know we're close to completing the migration of this route to frontend: alphagov/frontend#4950

Thanks, @andysellick. The changes in this PR are quite small (just opened for review now, but I don’t expect much else to change).

If I can get these changes released before you finish the migration, we can update your branch to include them - it’s only a line or two. Otherwise, if the migration goes in first, I’ll make a note to update the template in Frontend after our changes are merged.

Does that sound okay?

@andysellick
Copy link
Contributor

Thanks @jon-kirwan I'm in the middle of doing that route at the moment so I'll make a note to update it myself.

@jon-kirwan jon-kirwan force-pushed the update-inverse-header branch from 56de2a9 to 8e07c30 Compare November 3, 2025 10:52
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3860 November 3, 2025 10:52 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me and it should be possible to merge in advance of the latest inverse header style changes in the gem to avoid the wrong background colour being applied, or include the gem bump as part of this PR

hannalaakso and others added 2 commits November 6, 2025 12:26
This variant was previously doucumented in the gem docs but wasn't actually programatically being set anywhere. We now need to setit since it's got the standard blue background colour instead of the default light blue.
@jon-kirwan jon-kirwan force-pushed the update-inverse-header branch from 8e07c30 to f96dd63 Compare November 6, 2025 12:26
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3860 November 6, 2025 12:27 Inactive
@jon-kirwan jon-kirwan merged commit 5737e55 into main Nov 6, 2025
11 checks passed
@jon-kirwan jon-kirwan deleted the update-inverse-header branch November 6, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants