[PNP-9666] simplify layouts in frontend #5092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
requested review from
AshGDS,
andysellick,
deborahchua and
sairamya93
andysellick
reviewed
Oct 24, 2025
Contributor
andysellick
left a comment
andysellick
left a comment
There was a problem hiding this comment.
Much cleaner and easier to read 👍
Contributor
There was a problem hiding this comment.
Is it possible to have full width extend from the application layout? It seems like we end up duplicating a fair bit of stuff here.
Contributor
Author
There was a problem hiding this comment.
Hmm. There isn't really an extension mechanism in that sense, I think (you sort of can by having content_for blocks and then pointing one layout to the other, but I can't think of a good way to do that that doesn't do more damage than the current solution).
Contributor
There was a problem hiding this comment.
Okay, that's fair enough then.
- reorganize so that content for head: is at the top, then we have the layout component, then the body is inside that component's block.
- reorganize so that content for head: is at the top, then we have the layout component, then the body is inside that component's block.
KludgeKML
force-pushed
the
pnp-9666-simplify-layouts-in-frontend
branch
from
39d5dff to
98662f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The current layouts in frontend are inverted (body/head/call to layout) to support the individual component loading. Since we're not doing that at the moment, put the elements back in order.
This change is expected to make no visual difference to any page.
Why
https://gov-uk.atlassian.net/browse/PNP-9666