Skip to content

FlexiblePage Atom feed support should move out of Feed flexible section #5378

@KludgeKML

Description

@KludgeKML

As shown in #5377, having the Flexible Page Atom feeds information taken from the Feed section puts too much code into the Feed flexible section that's not directly related to what it does. It means that the Feed always loads 10 items (it needs 5, but the atom feed needs 10), then has to only display the first 5. It also means more passing of structures back and forth between the page and the section.

A better option would be to have the feed filters described in the flexible page subclass (for instance TopicalEvent), and then have a utility function in the FlexiblePage class that takes a filter and a number of results. We could then pass that directly to the atom feed, or pass it through a filter to the Feed section.

Metadata

Metadata

Assignees

Labels

tech-debtPull requests which introduce tech debt

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions