Option to force a different address, return ERROR if required change failed #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, a random address can be the same as the previous one. That patch adds a --different option that will try again if the we are unlucky enough to get a random one that is the same one. Some distributions such as tails are paranoid enough not to trust the exit code and will take drastic measures if macchange doesn't actually change the mac address. That option should help them.
Use the MAC address reading at the end as a double check.
|
It's not necessary to be paranoid to distrust macchanger's exit status, since it currently exits 0 (success) even if nothing at all was done due to wrong usage. So exit status doesn't have a clear meaning. Also, that the mac did not change is no reason to exit as failure. For example, you might want to go back to the permanent mac, whether or not you're already there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Here are a couple of pacthes:
They are independant, you can take one or both if you like them.
Cheers