Skip to content

Conversation

@zivoy
Copy link
Contributor

@zivoy zivoy commented Oct 20, 2025

Add an option to build the tools (xmllint and xmlcatalog).

Also removed the linking with readline with the main lib since its not used in it and just throws a warning during build.

@Techatrix
Copy link
Member

According to upstream CMakeLists.txt, the xmllint and xmlcatalog programs can be built without readline. The reason why this didn't work in the Zig port was because the config header that contains HAVE_LIBREADLINE was incorrectly generated.

There are some other points that would need to be addressed:

  • LIBXML_STATIC must be defined when building for windows with static linkage
  • the strip and pic options are missing
  • the -Dtools option is unnecessary. zig build install should install everything that upstream would also install by default. The build system is lazy so that projects that depend on this libxml port don't build the tools unless they depend on them.
  • xmlcatalog should only be available if "catalog" and "output" are enabled (at least that's what upstream does)

I have already made all of these changes locally and I will push them soon so that you don't have to redo all of this. Thanks for your work on this.

@Techatrix Techatrix closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants