Skip to content

Add AllureId attribute#291

Merged
neparij merged 2 commits intoallure-framework:mainfrom
dodopizza:feature/allureId
Sep 19, 2022
Merged

Add AllureId attribute#291
neparij merged 2 commits intoallure-framework:mainfrom
dodopizza:feature/allureId

Conversation

@alekskulakov
Copy link
Contributor

@alekskulakov alekskulakov commented Aug 31, 2022

Context

Added new Allure NUnit attribute because it's very inconvenient to write [AllureLabel("AS_ID", "123")] for every test.

Checklist


public override void UpdateTestResult(TestResult testResult)
{
testResult.labels.Add(new Label {name = "AS_ID", value = Id.ToString()});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ALLURE_ID instead (AS_ID supported but deprecated)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neparij neparij merged commit 319a6ad into allure-framework:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants