Skip to content

Conversation

@davidheineman
Copy link
Member

Incorporate this one-line PR: allenai/OLMo-in-loop-evals#12

TL;DR: #281 made in-loop RC and BPB slower, this fixes that bug. The RC/BPB in-loop evals run with ai2-olmo-eval~=0.8.0 are correct evals, just slower.

@davidheineman davidheineman requested a review from epwalsh May 27, 2025 15:58
@davidheineman
Copy link
Member Author

@epwalsh I think the docs build is failing on main, so the tests should be good here.

@epwalsh epwalsh merged commit aa96c3a into main May 27, 2025
25 of 27 checks passed
@epwalsh epwalsh deleted the rc-bpb-speed-fix branch May 27, 2025 21:39
TianhuaTao pushed a commit that referenced this pull request May 28, 2025
Incorporate this one-line PR:
allenai/OLMo-in-loop-evals#12

TL;DR: #281 made in-loop RC and
BPB slower, this fixes that bug. **The RC/BPB in-loop evals run with
`ai2-olmo-eval~=0.8.0` are correct evals, just slower.**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants