-
-
Notifications
You must be signed in to change notification settings - Fork 79
#268 Gridify should allow intermediate null vallues #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
alirezanet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great improvements 💐👌,
There are some discussion points about the configuration settings and a few minor changes required.
also please don't forget documentation if you add a new feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job, we're almost there.
I think two more changes is needed:
- One mistake in the default value (it should be
false) - Just to make sure it doesn't break the
Gridify.EntityFrameworkintegration, it would be nice if you could add two more test cases with database integration: one withAvoidNullReference = falseand one withAvoidNullReference = true. Both tests should behave as expected.
(I suggest to add it to theEntityFrameworkPostgreSqlIntegrationTestsproject)
alirezanet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks 💐
Description
Gridify should allow intermediate null values as per #268
Type of change
Checklist