Chore: Increase Test Coverage #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`delayed_reply` spawns a task which was inhibiting messages from OutboundSpy getting delivered to the correct process. This forwards those messages to the parent process to that they can be used in assertions.
adamzaninovich
commented
Apr 11, 2020
Comment on lines
+3
to
+4
| "lib/alice.ex", | ||
| "lib/alice/state_backends/redix_pool.ex" |
Member
Author
There was a problem hiding this comment.
These files are both Supervisors. There is actually a test file for lib/alice.ex that tests the one function that isn't part of the Supervisor spec.
adamzaninovich
commented
Apr 11, 2020
Comment on lines
-142
to
-145
| defp parse_function_doc({_function, _anno, _sig, _doc_content, _meta}, title) do | ||
| {title, nil, :hidden} | ||
| end | ||
|
|
Member
Author
There was a problem hiding this comment.
Pretty sure we don't need this fall-through version of the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly increases test coverage throughout project.