fix(test): handle zero limit in LuminaGlobalIndexTest#62
Merged
lxy-9602 merged 3 commits intoalibaba:mainfrom Jan 19, 2026
Merged
fix(test): handle zero limit in LuminaGlobalIndexTest#62lxy-9602 merged 3 commits intoalibaba:mainfrom
lxy-9602 merged 3 commits intoalibaba:mainfrom
Conversation
lxy-9602
force-pushed
the
fix-lumina-ut
branch
from
e164b71 to
8cb0c90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes an edge case in
LuminaGlobalIndexTestwhere randomly setting the vector search limit to0could lead to case fail.Linked issue: #5
Tests
LuminaGlobalIndexTest, TestHighCardinalityAndMultiThreadSearch