Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/paimon/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ if(PAIMON_BUILD_TESTS)
common/io/buffered_input_stream_test.cpp
common/io/memory_segment_output_stream_test.cpp
common/io/offset_input_stream_test.cpp
common/logging/logging_test.cpp
common/metrics/metrics_impl_test.cpp
common/options/memory_size_test.cpp
common/options/time_duration_test.cpp
Expand Down
2 changes: 1 addition & 1 deletion src/paimon/common/logging/logging.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ std::unique_ptr<Logger> Logger::GetLogger(const std::string& path) {
std::shared_lock<std::shared_mutex> lock(getRegistryLock());
return creator.value()(path);
}

std::unique_lock<std::shared_mutex> ulock(getRegistryLock());
if (!google::IsGoogleLoggingInitialized()) {
google::InitGoogleLogging(program_invocation_name);
}
Expand Down
39 changes: 39 additions & 0 deletions src/paimon/common/logging/logging_test.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/*
* Copyright 2025-present Alibaba Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "paimon/logging.h"

#include <future>
#include <random>
#include <thread>

#include "paimon/common/executor/future.h"
#include "paimon/executor.h"
#include "paimon/testing/utils/testharness.h"
namespace paimon::test {
TEST(LoggerTest, TestMultiThreadGetLogger) {
auto executor = CreateDefaultExecutor(/*thread_count*/ 4);
auto get_logger = []() {
auto logger = Logger::GetLogger("my_log");
ASSERT_TRUE(logger);
};

std::vector<std::future<void>> futures;
for (int i = 0; i < 1000; ++i) {
futures.push_back(Via(executor.get(), get_logger));
}
Wait(futures);
}
} // namespace paimon::test
Loading