fix: lazy create merge function in merge file split read#58
Merged
zjw1111 merged 1 commit intoalibaba:mainfrom Jan 17, 2026
Merged
fix: lazy create merge function in merge file split read#58zjw1111 merged 1 commit intoalibaba:mainfrom
zjw1111 merged 1 commit intoalibaba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid false "unsupported aggregation method" error reports in scenarios such as PK+DV where reading does not actually require MOR (merge-on-read).
Original version: When reading the PK table, if an unsupported aggregation method is encountered, an error is directly reported during the creation of the reader, regardless of whether the MOR is actually needed during the data reading process.
Updated to: The validation of the aggregation method support will only occur when the DataSplit data requires MOR, avoiding false error reports in scenarios such as PK+DV where reading does not actually require MOR.
Tests
TEST_P(ScanAndReadInteTest, TestWithPKWithDvWithInvalidAggregateBatchScanSnapshot3)
TEST_P(ScanAndReadInteTest, TestWithPKWithMorWithInvalidAggregateBatchScanSnapshot3)
API and Format
Documentation