fix(compile, ut): some compile/ut issues#29
Merged
lxy-9602 merged 5 commits intoalibaba:mainfrom Dec 25, 2025
Merged
Conversation
Contributor
Author
|
@lxy-9602 PTAL,Thanks |
lxy-9602
reviewed
Dec 23, 2025
Contributor
Author
|
@lxy-9602 @ChaomingZhangCN PTAL, thanks |
Contributor
|
In that case, the integration test case |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
I’m building the project with Blade, and I haven’t run the integration tests yet. I’ve already run into some issues with the unit tests, so I’ll look into them further. |
ChaomingZhangCN
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
background: compile and run under gcc8
1.
unordered_map iterate order is undefined, so make ut not depend on the order of return vector's element order
Tests
API and Format
Documentation