Skip to content

fix: correct nextRowId in global index snapshot test data #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lszskye merged 2 commits into from
Dec 18, 2025
Merged

fix: correct nextRowId in global index snapshot test data #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f27bde
fix(global-index): correct nextRowId in snapshot test data
lxy-9602 Dec 18, 2025
9f7b6e4
fix
lxy-9602 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/paimon/common/global_index/complete_index_score_batch_reader_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ class CompleteIndexScoreBatchReaderTest : public ::testing::Test {
}

std::unique_ptr<BatchReader> PrepareCompleteIndexScoreBatchReader(
const std::shared_ptr<arrow::Array>& src_array, const RoaringBitmap32& seleced_bitmap,
const std::shared_ptr<arrow::Array>& src_array, const RoaringBitmap32& selected_bitmap,
const std::vector<float>& scores, int32_t batch_size) const {
auto file_batch_reader = std::make_unique<MockFileBatchReader>(src_array, src_array->type(),
seleced_bitmap, batch_size);
selected_bitmap, batch_size);
return std::make_unique<CompleteIndexScoreBatchReader>(std::move(file_batch_reader), scores,
pool_);
}
Expand Down
2 changes: 1 addition & 1 deletion src/paimon/core/global_index/indexed_split_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ TEST(IndexedSplitTest, TestSimple) {
auto meta3 = std::make_shared<DataFileMeta>(
"file3.orc", 102l, 200l, BinaryRow::EmptyRow(), BinaryRow::EmptyRow(),
SimpleStats::EmptyStats(), SimpleStats::EmptyStats(), 1000l, 1199l, 0, 0,
std::vector<std::optional<std::string>>(), Timestamp(1765535214349, 0), 0, nullptr,
std::vector<std::optional<std::string>>(), Timestamp(1765535214349l, 0), 0, nullptr,
FileSource::Append(), std::nullopt, std::nullopt, 1000l, std::nullopt);

DataSplitImpl::Builder builder(
Expand Down
2 changes: 1 addition & 1 deletion src/paimon/format/orc/orc_input_output_stream_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ TEST(OrcInputOutputStreamTest, TestSimple) {

struct_batch = dynamic_cast<::orc::StructVectorBatch*>(batch.get());
ASSERT_TRUE(struct_batch);
int_batch = static_cast<::orc::LongVectorBatch*>(struct_batch->fields[0]);
int_batch = dynamic_cast<::orc::LongVectorBatch*>(struct_batch->fields[0]);
ASSERT_TRUE(int_batch);
double_batch = dynamic_cast<::orc::DoubleVectorBatch*>(struct_batch->fields[1]);
ASSERT_TRUE(double_batch);
Expand Down
2 changes: 1 addition & 1 deletion test/test_data/orc/append_with_global_index.db/append_with_global_index/snapshot/snapshot-1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 8,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion test/test_data/orc/append_with_global_index.db/append_with_global_index/snapshot/snapshot-2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 0,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion test/test_data/orc/append_with_global_index.db/append_with_global_index/snapshot/snapshot-3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 0,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion test/test_data/orc/append_with_global_index.db/append_with_global_index/snapshot/snapshot-4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 0,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion ...lobal_index_with_partition.db/append_with_global_index_with_partition/snapshot/snapshot-1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 8,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion ...lobal_index_with_partition.db/append_with_global_index_with_partition/snapshot/snapshot-2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 0,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion ...est_data/parquet/append_with_global_index.db/append_with_global_index/snapshot/snapshot-1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 8,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion ...est_data/parquet/append_with_global_index.db/append_with_global_index/snapshot/snapshot-2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 0,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion ...est_data/parquet/append_with_global_index.db/append_with_global_index/snapshot/snapshot-3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 0,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion ...est_data/parquet/append_with_global_index.db/append_with_global_index/snapshot/snapshot-4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 0,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion ...lobal_index_with_partition.db/append_with_global_index_with_partition/snapshot/snapshot-1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 8,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
2 changes: 1 addition & 1 deletion ...lobal_index_with_partition.db/append_with_global_index_with_partition/snapshot/snapshot-2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"totalRecordCount" : 8,
"deltaRecordCount" : 0,
"changelogRecordCount" : 0,
"nextRowId" : 0
"nextRowId" : 8
}
Loading