Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ TEST_F(CompleteIndexScoreBatchReaderTest, TestWithBitmap) {
["Alice", 10, null, 0],
["Bob", 11, null, 1],
["Cathy", 12, null, 2],
["Davlid", 13, null, 4]
["David", 13, null, 4]
])")
.ValueOrDie();

Expand All @@ -125,7 +125,7 @@ TEST_F(CompleteIndexScoreBatchReaderTest, TestWithBitmap) {
auto array_status =
arrow::ipc::internal::json::ChunkedArrayFromJSON(arrow::struct_(fields), {R"([
["Alice", 10, 1.23, 0],
["Davlid", 13, -19.12, 4]
["David", 13, -19.12, 4]
])"},
&expected_array);
ASSERT_TRUE(array_status.ok());
Expand Down
5 changes: 2 additions & 3 deletions src/paimon/common/global_index/global_index_result.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Result<PAIMON_UNIQUE_PTR<Bytes>> GlobalIndexResult::Serialize(
} else {
return Status::Invalid(
"invalid GlobalIndexResult, must be BitmapGlobalIndexResult or "
"BitmapTopkGlobalIndexResult");
"BitmapTopKGlobalIndexResult");
}
return MemorySegmentUtils::CopyToBytes(out.Segments(), 0, out.CurrentSize(), pool.get());
}
Expand All @@ -108,8 +108,7 @@ Result<std::shared_ptr<GlobalIndexResult>> GlobalIndexResult::Deserialize(
DataInputStream in(input_stream);
PAIMON_ASSIGN_OR_RAISE(int32_t version, in.ReadValue<int32_t>());
if (version != VERSION) {
return Status::Invalid(
fmt::format(fmt::format("invalid version {} for GlobalIndexResult", version)));
return Status::Invalid(fmt::format("invalid version {} for GlobalIndexResult", version));
}
PAIMON_ASSIGN_OR_RAISE(int32_t bitmap_bytes_len, in.ReadValue<int32_t>());
auto bitmap_bytes = Bytes::AllocateBytes(bitmap_bytes_len, pool.get());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,6 @@ TEST_F(GlobalIndexResultTest, TestInvalidSerialize) {
auto result = std::make_shared<FakeGlobalIndexResult>(std::vector<int64_t>({1, 3, 5, 100}));
ASSERT_NOK_WITH_MSG(GlobalIndexResult::Serialize(result, pool),
"invalid GlobalIndexResult, must be BitmapGlobalIndexResult or "
"BitmapTopkGlobalIndexResult");
"BitmapTopKGlobalIndexResult");
}
} // namespace paimon::test
2 changes: 1 addition & 1 deletion src/paimon/core/table/source/append_only_table_read.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Result<std::unique_ptr<BatchReader>> AppendOnlyTableRead::CreateReader(
return read->CreateReader(split);
}
}
return Status::Invalid("create reader failed, not read match with data split.");
return Status::Invalid("create reader failed, not read match with split.");
}

} // namespace paimon
2 changes: 1 addition & 1 deletion src/paimon/core/table/source/data_split_impl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ bool DataSplitImpl::TEST_Equal(const DataSplitImpl& other) const {

int64_t DataSplitImpl::PartialMergedRowCount() const {
if (!raw_convertible_) {
return 0l;
return 0;
}
int64_t sum = 0;
for (size_t i = 0; i < data_files_.size(); i++) {
Expand Down
Loading