Skip to content

Conversation

@Libres-coder
Copy link
Contributor

Ⅰ. Describe what this PR did

Fix CI test framework bug: e2e tests fail with go: updates to go.mod needed.

tools/hack/prebuild.sh updates submodules' go.mod but misses root go.mod. Added go mod tidy at the end to fix this.


Ⅱ. Does this pull request fix one issue?

Yes. Fixes CI test failures affecting all PRs that trigger wasm plugin e2e tests.


Ⅲ. Why don't you add test cases (unit test/integration test)?

CI automatically validates this fix when running e2e tests.


Ⅳ. Describe how to verify it

rm -rf external/
git submodule update --init
./tools/hack/prebuild.sh
git status  # Should show no changes to go.mod/go.sum

Or wait for CI "Build and Test Plugins" workflow to pass.


Ⅴ. Special notes for reviews

Critical infrastructure fix. 3 lines change, low risk. Recommend priority merge.

@lingma-agents
Copy link

lingma-agents bot commented Oct 28, 2025

修复CI测试框架中的go.mod更新问题

变更概述
  • 问题修复

    • 修复了CI测试框架中由于缺少对根目录go.mod文件的更新而导致的'e2e tests fail with go: updates to go.mod needed'错误。
    • tools/hack/prebuild.sh脚本末尾添加了go mod tidy -go=${GO_VERSION}命令,确保在处理完子模块后同步更新根模块的依赖。
    • 此修复解决了影响所有触发wasm插件e2e测试的PR的CI失败问题。
  • 配置调整

    • 修改了tools/hack/prebuild.sh脚本,在处理完istio相关子模块后执行全局的go mod tidy操作。
变更文件
文件路径 变更说明
tools/hack/prebuild.sh 在处理完所有istio子模块后,添加了"go mod tidy -go=${GO_VERSION}"命令来更新根目录的go.mod文件。
时序图
sequenceDiagram
    participant S as prebuild.sh
    participant SM as Submodules
    S->>SM: 处理istio子模块(go.mod更新)
    S->>S: 返回根目录
    S->>S: 执行go mod tidy -go=${GO_VERSION}
Loading

💡 小贴士

与 lingma-agents 交流的方式

📜 直接回复评论
直接回复本条评论,lingma-agents 将自动处理您的请求。例如:

  • 在当前代码中添加详细的注释说明。

  • 请详细介绍一下你说的 LRU 改造方案,并使用伪代码加以说明。

📜 在代码行处标记
在文件的特定位置创建评论并 @lingma-agents。例如:

  • @lingma-agents 分析这个方法的性能瓶颈并提供优化建议。

  • @lingma-agents 对这个方法生成优化代码。

📜 在讨论中提问
在任何讨论中 @lingma-agents 来获取帮助。例如:

  • @lingma-agents 请总结上述讨论并提出解决方案。

  • @lingma-agents 请根据讨论内容生成优化代码。

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.36%. Comparing base (ef31e09) to head (fb77fba).
⚠️ Report is 758 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3069      +/-   ##
==========================================
+ Coverage   35.91%   43.36%   +7.45%     
==========================================
  Files          69       82      +13     
  Lines       11576    10917     -659     
==========================================
+ Hits         4157     4734     +577     
+ Misses       7104     5853    -1251     
- Partials      315      330      +15     

see 97 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Libres-coder
Copy link
Contributor Author

Libres-coder commented Oct 28, 2025

@johnlanni @Xunzhuo @2456868764 ptal,thx


@johnlanni @Xunzhuo @2456868764 asked thx

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@johnlanni johnlanni merged commit 268cf71 into alibaba:main Oct 29, 2025
8 checks passed
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants