-
Notifications
You must be signed in to change notification settings - Fork 874
fix: update root go.mod in prebuild.sh to resolve CI test failures #3069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
修复CI测试框架中的go.mod更新问题变更概述
变更文件
时序图sequenceDiagram
participant S as prebuild.sh
participant SM as Submodules
S->>SM: 处理istio子模块(go.mod更新)
S->>S: 返回根目录
S->>S: 执行go mod tidy -go=${GO_VERSION}
💡 小贴士与 lingma-agents 交流的方式📜 直接回复评论
📜 在代码行处标记
📜 在讨论中提问
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
==========================================
+ Coverage 35.91% 43.36% +7.45%
==========================================
Files 69 82 +13
Lines 11576 10917 -659
==========================================
+ Hits 4157 4734 +577
+ Misses 7104 5853 -1251
- Partials 315 330 +15 🚀 New features to boost your workflow:
|
|
@johnlanni @Xunzhuo @2456868764 ptal,thx @johnlanni @Xunzhuo @2456868764 asked thx |
johnlanni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Ⅰ. Describe what this PR did
Fix CI test framework bug: e2e tests fail with
go: updates to go.mod needed.tools/hack/prebuild.shupdates submodules' go.mod but misses root go.mod. Addedgo mod tidyat the end to fix this.Ⅱ. Does this pull request fix one issue?
Yes. Fixes CI test failures affecting all PRs that trigger wasm plugin e2e tests.
Ⅲ. Why don't you add test cases (unit test/integration test)?
CI automatically validates this fix when running e2e tests.
Ⅳ. Describe how to verify it
rm -rf external/ git submodule update --init ./tools/hack/prebuild.sh git status # Should show no changes to go.mod/go.sumOr wait for CI "Build and Test Plugins" workflow to pass.
Ⅴ. Special notes for reviews
Critical infrastructure fix. 3 lines change, low risk. Recommend priority merge.