Skip to content

Conversation

@CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Sep 30, 2025

Ⅰ. Describe what this PR did

Higress 2.1.8 doesn't support setting match_rule_domain to an empty string in mcp-session filter. So when generating mcp-session configs from annotations, always use wildcard for match-all to eliminate the compatibility risk.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.95%. Comparing base (ef31e09) to head (132194a).
⚠️ Report is 734 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2973      +/-   ##
==========================================
+ Coverage   35.91%   44.95%   +9.04%     
==========================================
  Files          69       82      +13     
  Lines       11576    13378    +1802     
==========================================
+ Hits         4157     6014    +1857     
+ Misses       7104     7016      -88     
- Partials      315      348      +33     
Files with missing lines Coverage Δ
pkg/ingress/kube/annotations/mcpserver.go 93.87% <100.00%> (ø)

... and 79 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 096b97e into alibaba:main Oct 6, 2025
8 checks passed
@CH3CHO CH3CHO deleted the fix/mcp-server-domain-wildcard branch October 6, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants