Skip to content

Conversation

@erasernoob
Copy link
Collaborator

@erasernoob erasernoob commented Aug 21, 2025

Ⅰ. Describe what this PR did

The previously constructed pipeline for the plugin only compiled main.go and did not include other files in the directory, which could lead to compilation failures due to dependencies.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lingma-agents
Copy link

lingma-agents bot commented Aug 21, 2025

修复 WASM Go 插件构建命令以支持 wasip1/wasm 架构

变更概述
  • 问题修复

    • 修正了所有构建 WASM Go 插件的脚本和配置文件中的构建命令,以适配 wasip1/wasm 架构。
    • 更新了 GitHub Actions 工作流、Dockerfile 和 Makefile 中的 go build 命令,使用正确的环境变量和构建模式。
    • 修复目的:确保插件能够正确编译为 WASM 格式,以便在支持 wasip1 的运行时环境中执行。
  • 配置调整

    • 修改了 .github/workflows/build-and-push-wasm-plugin-image.yaml 中的构建步骤,添加 GOOS=wasip1 GOARCH=wasm 环境变量并设置 -buildmode=c-shared
    • plugins/wasm-go/Dockerfile 中更新了构建指令,以生成 /main.wasm 文件。
    • plugins/wasm-go/Makefile 中调整了 local-build 目标,使其能正确定位到插件目录并输出 main.wasm 文件。
变更文件
文件路径 变更说明
.​github/​workflows/​build-and-push-wasm-plugin-image.​yaml 更新了构建命令,指定 GOOS 和 GOARCH 为 wasip1/wasm,并使用 c-shared 构建模式来生成 plugin.wasm。
plugins/wasm-go/Dockerfile 修改了 Docker 构建阶段的 go build 命令,以支持 wasip1/wasm 架构,并输出 main.wasm 文件。
plugins/wasm-go/Makefile 更新 local-build 目标,切换到插件目录并使用正确的环境变量和构建选项生成 main.wasm。

💡 小贴士

与 lingma-agents 交流的方式

📜 直接回复评论
直接回复本条评论,lingma-agents 将自动处理您的请求。例如:

  • 在当前代码中添加详细的注释说明。

  • 请详细介绍一下你说的 LRU 改造方案,并使用伪代码加以说明。

📜 在代码行处标记
在文件的特定位置创建评论并 @lingma-agents。例如:

  • @lingma-agents 分析这个方法的性能瓶颈并提供优化建议。

  • @lingma-agents 对这个方法生成优化代码。

📜 在讨论中提问
在任何讨论中 @lingma-agents 来获取帮助。例如:

  • @lingma-agents 请总结上述讨论并提出解决方案。

  • @lingma-agents 请根据讨论内容生成优化代码。

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.29%. Comparing base (ef31e09) to head (01cc8db).
⚠️ Report is 667 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
+ Coverage   35.91%   45.29%   +9.38%     
==========================================
  Files          69       82      +13     
  Lines       11576    13224    +1648     
==========================================
+ Hits         4157     5990    +1833     
+ Misses       7104     6887     -217     
- Partials      315      347      +32     

see 79 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit df20472 into alibaba:main Aug 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants