-
Notifications
You must be signed in to change notification settings - Fork 866
Support OpenAI embedding. #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@CH3CHO 辛苦有时间帮忙review下~ |
好的。预计今天能给出 review 意见。另外麻烦先签署一下 CLA。谢谢! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
+ Coverage 35.91% 43.50% +7.59%
==========================================
Files 69 76 +7
Lines 11576 12325 +749
==========================================
+ Hits 4157 5362 +1205
+ Misses 7104 6627 -477
- Partials 315 336 +21 |
|
@duxin40 There are non-GitHub accounts in the historical commit messages, which cannot pass the CLA check |
Signed-off-by: duxin40 <[email protected]>
Signed-off-by: duxin40 <[email protected]>
Signed-off-by: duxin40 <[email protected]>
|
@CH3CHO @johnlanni thanks for the reminder, i have passed the CLA, plz help review again~ |

Ⅰ. Describe what this PR did
This PR is to support openai embedding.
Ⅱ. Does this pull request fix one issue?
Fix #1443.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
docker-compose.yaml:
envoy.yaml:
request:
embedding response log:

Ⅴ. Special notes for reviews