Skip to content

Fix pg refresh materialized view concurrently #6500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pg refresh materialized view concurrently #6500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/com/alibaba/druid/sql/parser/SQLStatementParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,11 +1037,12 @@ public SQLStatement parseRefresh() {

acceptIdentifier("MATERIALIZED");

accept(Token.VIEW);

if (lexer.identifierEquals("CONCURRENTLY")) {
lexer.nextToken();
stmt.setConcurrently(true);
}
accept(Token.VIEW);

stmt.setName(this.exprParser.name());

Expand Down
6 changes: 3 additions & 3 deletions core/src/main/java/com/alibaba/druid/sql/visitor/SQLASTOutputVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9302,12 +9302,12 @@ public boolean visit(SQLShowCreateMaterializedViewStatement x) {
public boolean visit(SQLRefreshMaterializedViewStatement x) {
print0(ucase ? "REFRESH MATERIALIZED" : "refresh materialized");

print0(ucase ? " VIEW " : " view ");

if (x.isConcurrently()) {
print0(ucase ? " CONCURRENTLY" : " concurrently");
print0(ucase ? "CONCURRENTLY " : "concurrently ");
}

print0(ucase ? " VIEW " : " view ");

x.getName().accept(this);

if (x.isWithNoData()) {
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/resources/bvt/parser/postgresql/15.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
refresh materialized concurrently view v1 with no data
refresh materialized view concurrently v1 with no data
--------------------
REFRESH MATERIALIZED CONCURRENTLY VIEW v1 WITH NO DATA
REFRESH MATERIALIZED VIEW CONCURRENTLY v1 WITH NO DATA