Skip to content

feat: enhance support for oracle using_index_clause #6461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: enhance support for oracle using_index_clause #6461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab252eb
feat: enhance support using_index_clause
zchazc Jun 18, 2025
6837adf
feat: more support using_index_clause
zchazc Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/java/com/alibaba/druid/sql/dialect/oracle/parser/OracleExprParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1210,6 +1210,12 @@ private OracleUsingIndexClause parseUsingIndex() {
OracleCreateIndexStatement createIndex = new OracleStatementParser(lexer).parseCreateIndex();
using.setIndex(createIndex);
accept(Token.RPAREN);
} else if (lexer.token() == Token.LITERAL_ALIAS || lexer.token() == Token.IDENTIFIER) {
//https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/constraint.html#GUID-1055EA97-BA6F-4764-A15F-1024FD5B6DFE__CJAGEBIG
using.setIndex(this.name());
} else {
throw new ParserException("syntax error, expect '('/LITERAL_ALIAS/IDENTIFIER, actual " + lexer.token() + " "
+ lexer.info());
}

for (; ; ) {
Expand Down
124 changes: 124 additions & 0 deletions core/src/test/java/com/alibaba/druid/sql/dialect/oracle/parser/OracleUsingIndexTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
package com.alibaba.druid.sql.dialect.oracle.parser;

import com.alibaba.druid.DbType;
import com.alibaba.druid.sql.SQLUtils;
import com.alibaba.druid.sql.ast.SQLStatement;
import com.alibaba.druid.sql.ast.statement.SQLAlterTableAddConstraint;
import com.alibaba.druid.sql.ast.statement.SQLAlterTableItem;
import com.alibaba.druid.sql.ast.statement.SQLAlterTableStatement;
import com.alibaba.druid.sql.ast.statement.SQLConstraint;
import com.alibaba.druid.sql.dialect.oracle.ast.stmt.OraclePrimaryKey;
import com.alibaba.druid.sql.dialect.oracle.ast.stmt.OracleUsingIndexClause;
import org.junit.Assert;
import org.junit.Test;

import com.alibaba.druid.sql.parser.ParserException;
import java.util.NoSuchElementException;

public class OracleUsingIndexTest {


@Test
public void testUsingLiteralIndex() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX \"SC\".\"PK_XXX\"";
SQLStatement stat = SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
System.out.println(stat);
Assert.assertTrue(stat instanceof SQLAlterTableStatement);
SQLAlterTableItem sqlAlterTableItem = ((SQLAlterTableStatement) stat).getItems().stream().findAny()
.orElseThrow(NoSuchElementException::new);
Assert.assertTrue(sqlAlterTableItem instanceof SQLAlterTableAddConstraint);
SQLConstraint constraint = ((SQLAlterTableAddConstraint) sqlAlterTableItem).getConstraint();
Assert.assertTrue(constraint instanceof OraclePrimaryKey);
OracleUsingIndexClause usingIndexClause = ((OraclePrimaryKey) constraint).getUsing();
Assert.assertEquals("\"SC\".\"PK_XXX\"", usingIndexClause.getIndex().toString());
Assert.assertEquals(sql, stat.toString());
System.out.println("=============");
}

@Test
public void testUsingIndexWithoutSchema() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX \"PK_XXX\"";
SQLStatement stat = SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
System.out.println(stat);
Assert.assertTrue(stat instanceof SQLAlterTableStatement);
SQLAlterTableItem sqlAlterTableItem = ((SQLAlterTableStatement) stat).getItems().stream().findAny()
.orElseThrow(NoSuchElementException::new);
Assert.assertTrue(sqlAlterTableItem instanceof SQLAlterTableAddConstraint);
SQLConstraint constraint = ((SQLAlterTableAddConstraint) sqlAlterTableItem).getConstraint();
Assert.assertTrue(constraint instanceof OraclePrimaryKey);
OracleUsingIndexClause usingIndexClause = ((OraclePrimaryKey) constraint).getUsing();
Assert.assertEquals("\"PK_XXX\"", usingIndexClause.getIndex().toString());
Assert.assertEquals(sql, stat.toString());
System.out.println("=============");
}

@Test
public void testUsingIdentifierIndex() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX SC.PK_XXX";
SQLStatement stat = SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
System.out.println(stat);
Assert.assertTrue(stat instanceof SQLAlterTableStatement);
SQLAlterTableItem sqlAlterTableItem = ((SQLAlterTableStatement) stat).getItems().stream().findAny()
.orElseThrow(NoSuchElementException::new);
Assert.assertTrue(sqlAlterTableItem instanceof SQLAlterTableAddConstraint);
SQLConstraint constraint = ((SQLAlterTableAddConstraint) sqlAlterTableItem).getConstraint();
Assert.assertTrue(constraint instanceof OraclePrimaryKey);
OracleUsingIndexClause usingIndexClause = ((OraclePrimaryKey) constraint).getUsing();
Assert.assertEquals("SC.PK_XXX", usingIndexClause.getIndex().toString());
Assert.assertEquals(sql, stat.toString());
System.out.println("=============");
}

@Test
public void testUsingIdentifierIndexWithoutSchema() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX PK_XXX";
SQLStatement stat = SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
System.out.println(stat);
Assert.assertTrue(stat instanceof SQLAlterTableStatement);
SQLAlterTableItem sqlAlterTableItem = ((SQLAlterTableStatement) stat).getItems().stream().findAny()
.orElseThrow(NoSuchElementException::new);
Assert.assertTrue(sqlAlterTableItem instanceof SQLAlterTableAddConstraint);
SQLConstraint constraint = ((SQLAlterTableAddConstraint) sqlAlterTableItem).getConstraint();
Assert.assertTrue(constraint instanceof OraclePrimaryKey);
OracleUsingIndexClause usingIndexClause = ((OraclePrimaryKey) constraint).getUsing();
Assert.assertEquals("PK_XXX", usingIndexClause.getIndex().toString());
Assert.assertEquals(sql, stat.toString());
System.out.println("=============");
}

@Test
public void testIncompleteUsingIndex() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX";
try {
SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
throw new RuntimeException("not ParserException");
}catch (Throwable e){
Assert.assertTrue(e instanceof ParserException);
Assert.assertEquals(e.getMessage(),"syntax error, expect '('/LITERAL_ALIAS/IDENTIFIER, actual EOF pos 80, line 3, column 14, token EOF");
}
}

@Test
public void testWrongUsingIndex() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX ENABLE";
try {
SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
throw new RuntimeException("not ParserException");
}catch (Throwable e){
Assert.assertTrue(e instanceof ParserException);
Assert.assertEquals(e.getMessage(),"syntax error, expect '('/LITERAL_ALIAS/IDENTIFIER, actual ENABLE pos 87, line 3, column 15, token ENABLE");
}
}
}