This repository was archived by the owner on Feb 8, 2023. It is now read-only.
test: add test about execSync with wrong command #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we directly merge code to the master branch? |
starnop
force-pushed
the
cri-exec-test
branch
from
3f376aa to
5890e3d
Compare
|
@allencloud A new branch will be better. Would you mind creating a new branch ? |
I agree with creating a new one. |
|
@allencloud Done. ^_^ |
Ace-Tang
reviewed
Sep 12, 2018
pkg/validate/container.go
Outdated
| startContainer(rc, containerID) | ||
|
|
||
| By("test execSync") | ||
| cmd := []string{"cmd"} |
There was a problem hiding this comment.
Better to change cmd to not-exist-command.
starnop
force-pushed
the
cri-exec-test
branch
from
5890e3d to
48d9fc3
Compare
Signed-off-by: Starnop <[email protected]>
starnop
force-pushed
the
cri-exec-test
branch
from
48d9fc3 to
3e7a38b
Compare
|
LGTM |
|
Sorry for enter the wrong key and close the pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]