Skip to content

fix: order with empty array#17

Open
xwang1024 wants to merge 1 commit intoali-sdk:masterfrom
xwang1024:master
Open

fix: order with empty array#17
xwang1024 wants to merge 1 commit intoali-sdk:masterfrom
xwang1024:master

Conversation

@xwang1024
Copy link

If the options.orders is an empty array when selecting data, there will be an ER_PARSE_ERROR: You have an error in your SQL syntax; error, because Operator._orders returns string: " ORDER BY ", with no attributes.

A bit similar to #15 .

@mention-bot
Copy link

@xwang1024, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @csbun and @fangk to be potential reviewers.

@codecov-io
Copy link

codecov-io commented Mar 9, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@e8d8056). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   98.95%           
=========================================
  Files             ?        6           
  Lines             ?      288           
  Branches          ?       44           
=========================================
  Hits              ?      285           
  Misses            ?        3           
  Partials          ?        0
Impacted Files Coverage Δ
lib/operator.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d8056...964964c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants