profile/list: show errors in table listing instead of failing#145
Merged
Conversation
Without annotation the error is not helpful when you have multiple profiles. This also appears to require an AdminAPIKey, which might need another change to ammend.
Contributor
Author
|
FYI @helenamariano this from our conversation. |
Contributor
|
Thanks for the PR @dhowden 👍 What do you think about gracefully failing, like displaying the error for the profile in the
I'm happy to take over the PR if you don't have the time, let me know :) |
Contributor
Author
|
Hey @clemfromspace. No worries, I've updated the change to put the error in the table as suggested. Happy for you to take it from here to get it over the line! |
dhowden
changed the title
clemfromspace
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without annotation the error is not helpful when you have multiple profiles.
Note: this also uses the AdminAPIKey, which might need another change to amend.