fix: import of rules and synonyms#118
Merged
Merged
Conversation
… disable clear existing after the first batch
…g and disable replace existing after the first batch
Nagriar
changed the title
clemfromspace
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains 2 fixes:
Clear rules/synoyms when empty batch is provided with clear existing
When the input is empty no batches are sent which led to keeping the existing rules/synonyms.
The expected behaviour is to clear the existing rules/synonyms.
Since the API rejected empty batches, the clear endpoint is required for this specific case.
Disable clear existing after the first batch
If the input contains more than 1000 items, the cli splits the input into several batches but if the flag
ClearExistingRules/ReplaceExistingSynonymsis provided, only the last batch will be kept.This PR set the flag only for the first batch.
Test strategy
unit tests has been added to test both fixes