Skip to content

fix(autocomplete-js): avoid warning when renderer is not specified at all#947

Merged
sarahdayan merged 2 commits intonextfrom
fix/warning-false-positive
Apr 12, 2022
Merged

fix(autocomplete-js): avoid warning when renderer is not specified at all#947
sarahdayan merged 2 commits intonextfrom
fix/warning-false-positive

Conversation

@sarahdayan
Copy link
Copy Markdown
Member

The renderer.render warning should only show up when providing the render option and not poviding renderer.render, but not when render isn't specified at all.

This fix ensures the warning doesn't show up when you're only providing render without specifying renderer at all.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Apr 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f66a990:

Sandbox Source
algolia/autocomplete Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
algolia/autocomplete Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Copy link
Copy Markdown
Contributor

@FabienMotte FabienMotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahdayan sarahdayan merged commit 5fbae0d into next Apr 12, 2022
@sarahdayan sarahdayan deleted the fix/warning-false-positive branch April 12, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants