feat(js): sync detached mode open state#556
Merged
francoischalifour merged 3 commits intonextfrom Apr 30, 2021
Merged
Conversation
This synchronizes the internal open state with the detached overlay open state.
Haroenv
approved these changes
Apr 30, 2021
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
looks great! in the linked sandbox with this PR it seems like the modal also successfully closes when you want it to
sarahdayan
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This synchronizes the internal open state with the detached overlay open state.
It was a missing behavior that caused some trouble to users, unable to trigger an action (other than a link) after a selection on detached mode.
Changes
We're now syncing the detached open state with the internal
isOpenstate. This means thatshouldPanelOpenalways returntrueon detached mode now. Otherwise, the detached overlay wouldn't be able to stay open under user conditions.Related