fix(types): fix collision between js/core and plugins#532
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6cde30:
|
c981dd5 to
eeb1c32
Compare
eeb1c32 to
29ac919
Compare
|
@francoischalifour I've removed the |
francoischalifour
left a comment
There was a problem hiding this comment.
Nice! Good to merge once the last piece of feedback is addressed.
| "main": "index.html", | ||
| "scripts": { | ||
| "build": "parcel build index.html", | ||
| "build": "parcel build index.html --dist-dir ./dist", |
There was a problem hiding this comment.
Why do we need this?
There was a problem hiding this comment.
On my side, running the actual yarn build in parcel 2.0.0-beta.2 will output the build in the root folder.
Could you confirm this is also the case for you? If so, I'll update the other examples
There was a problem hiding this comment.
It builds it in the right folder for me.
What command did you run and from where?
There was a problem hiding this comment.
From the example folder (the root), with yarn build, yarn start works though.
Summary
There was a collision between the
AutocompleteOptions/AutocompletePlugintypes in js/core, which is now partially solved by making them looser.