feat(js): pass elements record to render#490
Merged
francoischalifour merged 1 commit intonextfrom Mar 8, 2021
Merged
Conversation
This adds an API to easily retrieve generated UI elements to manipulate the panel UI.
```
import { render } from 'preact';
autocomplete({
// ...
plugins: [recentSearchesPlugin, querySuggestionsPlugin],
getSources({ query }) {
return [
{
sourceId: 'products',
// ...
},
];
},
render({ elements }, root) {
const { recentSearchesPlugin, querySuggestionsPlugin, products } = elements;
render(
<div className="aa-PanelLayout">
<div>
{recentSearchesPlugin}
{querySuggestionsPlugin}
</div>
<div>{products}</div>
</div>,
root
);
},
});
```
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 09f19ee:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an API to easily retrieve generated UI elements to manipulate the panel UI.
Why
Finding the right source to render in the panel was cumbersome, and sometimes created friction to generate advanced conditional layouts.
How
We use the
sourceId(which is required) as the key to theelementsrecord:This makes flows easier to render because with flows, some key values can be
undefined(becausegetSourcesdoesn't return them). In JSX, renderingundefinedrenders nothing, which is convenient.API
Before
After
Single flow
Multiple flows