fix(a11y) Fix aria-label being not present when the option is set

[tryzniak]

Summary

I found a bug where an aria-label attribute could not be set using <input aria-label="blah" /> or autocomplete.js options. It just wasn't there.

Result

This PR fixes this issue by passing ariaLabel from autocomplete options to Typeahead.

[Haroenv]

Interesting that this didn't pass the test case made in #195. Do you think you can add a test case which failed before this PR? It should be in a file like this one: https://github.com/algolia/autocomplete.js/blob/master/test/unit/typeahead_spec.js

[tryzniak]

I'll try to write a regression test. It's an integration issue between Typeahead and autocomplete modules though. So I think https://github.com/algolia/autocomplete.js/blob/master/test/unit/typeahead_spec.js won't work here, because it's a unit test. But thank you for the nudge :)

[tryzniak]

Wow I've been trying to run integration tests for an hour but to no avail. Somehow I need to write a test that autocomplete's options.ariaLabel is passed to Typeahead. Any ideas?

[vvo]

Only tests PRS opened by contributors will have their tests passing because we use travis encrypted variables

[vvo]

(otherwise launch travis tests manually and it works for contributors I guess)

[coveralls]

Coverage remained the same at 88.854% when pulling 78f6942 on tryzniak:fix/input-aria-label into 0e65fee on algolia:master.

[tryzniak]

@Haroenv @vvo , I looked at travis' logs and they output Not running any tests. Which is suspicious. Maybe tests are not running at all? Because I even added a failing test just to see that they were not passing, but instead they were. Or am I doing something wrong here haha.

[kontrollanten]

I created PR #276 before I saw this. In my solution the aria-label is read from the input element though. I think that solution feels more natural. What do you say, @tryzniak ?

[tryzniak]

I can’t work on this pr in the near future, so if your pr is good to go by all means merge it in instead of mine.

…

On Dec 18, 2018, at 14:17, kontrollanten ***@***.***> wrote: I created PR #276 before I saw this. In my solution the aria-label is read from the input element though. I think that solution feels more natural. What do you say, @tryzniak ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[francoischalifour]

Autocomplete v0 has been in low maintenance mode for a few years and we just released Autocomplete v1 so I'm closing this.

Thanks for your contribution @tryzniak!