Skip to content

fix(autocomplete-preset-algolia): support Unicode in ReverseHighlight #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haroenv merged 1 commit into from
Feb 2, 2026
+96 −2
Merged

fix(autocomplete-preset-algolia): support Unicode in ReverseHighlight #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions packages/autocomplete-preset-algolia/src/highlight/__tests__/isPartHighlighted.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,92 @@ describe('isPartHighlighted', () => {
)
).toEqual(true);
});

// Japanese (俺はジャイアン): start / middle / end

test('does not treat Japanese text as a separator at the start (俺はジャイアン)', () => {
expect(
isPartHighlighted(
[
{ isHighlighted: false, value: '俺は' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: true, value: 'ジャイアン' },
],
0
)
).toEqual(false);
});

test('does not treat Japanese text as a separator in the middle (俺はジャイアンだ)', () => {
expect(
isPartHighlighted(
[
{ isHighlighted: true, value: '俺は' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: false, value: 'ジャイアン' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: true, value: 'だ' },
],
2
)
).toEqual(false);
});

test('does not treat Japanese text as a separator at the end (俺はジャイアンだ)', () => {
expect(
isPartHighlighted(
[
{ isHighlighted: true, value: '俺は' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: true, value: 'ジャイアン' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: false, value: 'だ' },
],
4
)
).toEqual(false);
});

// Cyrillic (regression #1317): start / middle / end

test('does not treat Cyrillic text as a separator at the start (regression #1317)', () => {
expect(
isPartHighlighted(
[
{ isHighlighted: false, value: 'привет' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: true, value: 'мир' },
],
0
)
).toEqual(false);
});

test('does not treat Cyrillic text as a separator in the middle (regression #1317)', () => {
expect(
isPartHighlighted(
[
{ isHighlighted: true, value: 'привет' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: false, value: 'мир' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: true, value: 'привет' },
],
2
)
).toEqual(false);
});

test('does not treat Cyrillic text as a separator at the end (regression #1317)', () => {
expect(
isPartHighlighted(
[
{ isHighlighted: true, value: 'привет' },
{ isHighlighted: false, value: ' ' },
{ isHighlighted: false, value: 'мир' },
],
2
)
).toEqual(false);
});
});
10 changes: 8 additions & 2 deletions packages/autocomplete-preset-algolia/src/highlight/isPartHighlighted.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ const htmlEscapes = {
'"': '"',
''': "'",
};
const hasAlphanumeric = new RegExp(/\w/i);
const hasLetterOrNumber = (() => {
try {
return new RegExp('[\\p{L}\\p{N}_]', 'u');
} catch {
return new RegExp(/\w/i);
}
})();
const regexEscapedHtml = /&(amp|quot|lt|gt|#39);/g;
const regexHasEscapedHtml = RegExp(regexEscapedHtml.source);

Expand All @@ -23,7 +29,7 @@ export function isPartHighlighted(parts: ParsedAttribute[], i: number) {
const isPreviousHighlighted = parts[i - 1]?.isHighlighted || true;

if (
!hasAlphanumeric.test(unescape(current.value)) &&
!hasLetterOrNumber.test(unescape(current.value)) &&
isPreviousHighlighted === isNextHighlighted
) {
return isPreviousHighlighted;
Expand Down