fix(core): use updated aria control attribute for root element#1278
Merged
fix(core): use updated aria control attribute for root element#1278
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34bd1df:
|
sarahdayan
approved these changes
Oct 14, 2024
Member
sarahdayan
left a comment
There was a problem hiding this comment.
LGTM!
A good improvement for the future would be to include automated Axe Core tests in our CI to flag those issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
getRootProps()to returnaria-controlsinstead ofaria-owns, following the latest ARIA specs.From MDN:
Result
Assistive technologies correctly link the combobox with the listbox it controls. Accessibility tools like WAVE and axe stop reporting errors relevant to this.
Closes #1271